Skip to content

[Non-breaking changes] Chore: Update derive SHA for stacktrie#375

Closed
c98tristan wants to merge 27 commits intoBuildOnViction:upgrade-core-developfrom
c98tristan:feat/update-trie-to-stacktrie
Closed

[Non-breaking changes] Chore: Update derive SHA for stacktrie#375
c98tristan wants to merge 27 commits intoBuildOnViction:upgrade-core-developfrom
c98tristan:feat/update-trie-to-stacktrie

Conversation

@c98tristan
Copy link
Contributor

@c98tristan c98tristan commented Jul 24, 2023 •
edited
Loading

This PR update deriveSha function for stacktrie. DeriveSha creates the tree hashes of transactions, receipts, and withdrawals in a block header.

goos: darwin
goarch: amd64
pkg: github.com/tomochain/tomochain/core/types
cpu: VirtualApple @ 2.50GHz
                        │     old     │                new                 │
                        │   sec/op    │   sec/op     vs base               │
DeriveSha200/std_trie-8   215.6µ ± 2%   198.2µ ± 1%  -8.04% (p=0.000 n=20)

                        │      old      │                 new                  │
                        │     B/op      │     B/op      vs base                │
DeriveSha200/std_trie-8   279.85Ki ± 0%   61.23Ki ± 0%  -78.12% (p=0.000 n=20)

                        │     old     │                 new                 │
                        │  allocs/op  │  allocs/op   vs base                │
DeriveSha200/std_trie-8   2.888k ± 0%   1.647k ± 0%  -42.97% (p=0.000 n=20)

Dang Nhat Trinh and others added 24 commits June 16, 2023 14:30
implements RLP encoding/decoding processing for structs
8253211
Update RLP lib
fa67be8
Implement RLP encoder code generation tool
9b5dadb
Update unit tests and benchmark
ddf35f8
Include RLPgen tool to CI
17e4876
Add benchmarks for types RLP encoding/decoding
aa7c4b4
Generate RLP encoder for some structs
ac89cd3
Convert status of receipts from uint to uint64
060f4ce 
Reference: ethereum/go-ethereum#16784
Unify multiple keccak interface into one inside crypto package
8fdaf68
Merge branch 'refactor/keccak-state' into ft/stacktrie
c7be6cc
Add encode method to Node interface
340bf2b
Implement stacktrie
33149c9
Add encode method for rawShortNode and rawFullNode
2e9abc4
Fix import cycle
008274f
Fix stacktrie unit tests
f88dba4
Remove rlpLog RLP encoder
327c90d
Fix unit tests
4d22f8d
@c98tristan
chore: remove intPool
024181b
@c98tristan
Feat: Update derive SHA for stacktrie
c384646
@c98tristan
Chore: Add benchmark for Stacktrie
b8421e5
@c98tristan
Chore: Fix Update function missing return type
6099609
@c98tristan
Chore: Change GetRlp to EncodeIndex in LendingTransaction and OrderTr…
ae6ca82 
…ansaction
@c98tristan
Update DeriveSha with new Hasher and DerivableList interface
515a614
@c98tristan
Chore: Add intPool in interpreter.go
44d2c54
trinhdn2
trinhdn2 suggested changes Jul 25, 2023
View reviewed changes
Copy link

@trinhdn2 trinhdn2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure that the test units are updated alongside with these changes. There are lots of untouched hashing operations in unit tests.

@trinhdn2
Copy link

trinhdn2 commented Jul 25, 2023

This PR can be marked as non-breaking, and the merge destination needs to be changed from tomochain:master to tomochain:upgrade-core-develop

@c98tristan c98tristan changed the base branch from master to upgrade-core-develop July 25, 2023 07:18
@c98tristan c98tristan changed the title Chore: Update derive SHA for stacktrie [Non-breaking] Chore: Update derive SHA for stacktrie Jul 25, 2023
@c98tristan c98tristan changed the title [Non-breaking] Chore: Update derive SHA for stacktrie [Non-breaking changes] Chore: Update derive SHA for stacktrie Jul 25, 2023
@c98tristan c98tristan force-pushed the feat/update-trie-to-stacktrie branch from 08dbcbb to 72ca227 Compare July 25, 2023 09:54
@trinhdn2 trinhdn2 force-pushed the feat/update-trie-to-stacktrie branch from 25f9c44 to 260f47e Compare August 1, 2023 04:18
@tungng98 tungng98 deleted the branch BuildOnViction:upgrade-core-develop December 10, 2023 16:51
@tungng98 tungng98 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trinhdn2 trinhdn2 trinhdn2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c98tristan @trinhdn2 @tungng98